Replace abstract handlers, customer handlers, type annotations, refactoring.#242
Merged
jordaneremieff merged 3 commits intomainfrom Feb 26, 2022
Merged
Replace abstract handlers, customer handlers, type annotations, refactoring.#242jordaneremieff merged 3 commits intomainfrom
jordaneremieff merged 3 commits intomainfrom
Conversation
…tom handlers, various type annotation fixes and additions, remove dataclasses, update README and requirements.
…o refactor-handlers-2
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
…ing additions and fixes, refactoring. (Kludex#242) * 🎨 Replace abstract handlers and introduce provisional support for custom handlers, various type annotation fixes and additions, remove dataclasses, update README and requirements. * 💥 Drop support for Python 3.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big refactoring and change to how the handlers will be designed going forward. I'm starting with the something that will make it easy to support custom handlers that could (potentially) be extended to support multiple vendors beyond AWS. The custom handlers can probably be used to support some other AWS use-cases more generally as well, so I've marked them as "provisional" until I'm more clear on how this will end up.
Changes:
Protocolimplementation to cover handling of handler inference, request body, scope parsing, and response handling.